Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove processColor #1367

Merged
merged 1 commit into from
Mar 23, 2022
Merged

fix: remove processColor #1367

merged 1 commit into from
Mar 23, 2022

Conversation

WoLewicki
Copy link
Member

Description

Removed unnecessary processColor which was added by mistake since the statusBarColor did not work without customType = "Color" in its @ReactProp.

Test code and steps to reproduce

Test860.tsx to see that it still works correctly after this change.

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

kkafar
kkafar approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@WoLewicki WoLewicki merged commit 14ea88d into main Mar 23, 2022
@WoLewicki WoLewicki deleted the @wolewicki/remove-unnecessary-color-processing branch March 23, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkafar kkafar kkafar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WoLewicki @kkafar